Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling the preferences dialog still makes changes to the preferences #1100

Open
sparkhi opened this issue Apr 30, 2024 · 2 comments
Open
Assignees
Projects

Comments

@sparkhi
Copy link
Collaborator

sparkhi commented Apr 30, 2024

Steps to reproduce:

  1. Launch preferences
  2. Uncheck one of the zip processing
  3. Click "Cancel"
  4. Open preferences again, the checkbox from step 2 remains unchecked (i.e. unknowingly some setting has changed - BUG)

Seen as far back as v6.5.2

@steve-daly
Copy link

Thanks. This is interesting. It looks like the subtle difference between the Cancel and OK buttons is that if you press OK the settings survive a restart of the application, whereas if you press Cancel they apply during the session but don't survive a restart. Not as intended though, as you say.

@sparkhi
Copy link
Collaborator Author

sparkhi commented Apr 30, 2024

It looks like the setting change does not take effect, but it is misleading to the user.

@sparkhi sparkhi self-assigned this May 16, 2024
@sparkhi sparkhi added this to To Do in Droid 6.8.0 May 16, 2024
@sparkhi sparkhi moved this from To Do to Done in Droid 6.8.0 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants