From c486d35ce7c6393eafc40dc082b75fc684c1a363 Mon Sep 17 00:00:00 2001 From: Sangjoon Bob Lee Date: Mon, 11 Nov 2024 11:53:52 -0500 Subject: [PATCH 1/2] Update release_checklist.md - use fourigui 0.2.0 version --- .github/ISSUE_TEMPLATE/release_checklist.md | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/release_checklist.md b/.github/ISSUE_TEMPLATE/release_checklist.md index 0f560278..33410e8c 100644 --- a/.github/ISSUE_TEMPLATE/release_checklist.md +++ b/.github/ISSUE_TEMPLATE/release_checklist.md @@ -6,26 +6,35 @@ labels: "release" assignees: "" --- -### PyPI/GitHub release checklist: +### PyPI/GitHub rc-release preparation checklist: - [ ] All PRs/issues attached to the release are merged. - [ ] All the badges on the README are passing. - [ ] License information is verified as correct. If you are unsure, please comment below. - [ ] Locally rendered documentation contains all appropriate pages, including API references (check no modules are missing), tutorials, and other human written text is up-to-date with any changes in the code. -- [ ] Installation instructions in the README, documentation and on the website (e.g., diffpy.org) are updated. +- [ ] Installation instructions in the README, documentation and on the website (e.g., diffpy.org) are updated. - [ ] Successfully run any tutorial examples or do functional testing with the latest Python version. - [ ] Grammar and writing quality are checked (no typos). -Please mention @sbillinge here when you are ready for PyPI/GitHub release. Include any additional comments necessary, such as -version information and details about the pre-release here: +Please mention @sbillinge here when you are ready for PyPI/GitHub release. Include any additional comments necessary, such as version information and details about the pre-release here: -### conda-forge release checklist: +### PyPI/GitHub full-release preparation checklist: +- [ ] Create a new conda environment and install the rc from pypi (`pip install =??`) +- [ ] License information at Pypi is verified as correct. +- [ ] Docs deployed successfully to `.github.io` +- [ ] Successfully run all tests, tutorial examples or do functional testing + +Please let @sbillinge know that all checks are done and package is ready for full release. + +### conda-forge release preparation checklist: +- [ ] Ensure that the full release has appeared on Pypi successfully - [ ] New package dependencies listed in `conda.txt` and `test.txt` are added to `meta.yaml` in the feedstock. -- [ ] All relevant issues in the feedstock are addressed in the release PR. +- [ ] Close any open issues on the feedstock. Reach out to @bobleesj if you have questions +- [ ] let @sbillinge and @bobleesj when this is ready ### Post-release checklist From 1831b797f9a5cb1edab47b5aaff1898ba537aa02 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 11 Nov 2024 16:54:46 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit hooks --- .github/ISSUE_TEMPLATE/release_checklist.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/release_checklist.md b/.github/ISSUE_TEMPLATE/release_checklist.md index 33410e8c..ba1d40ce 100644 --- a/.github/ISSUE_TEMPLATE/release_checklist.md +++ b/.github/ISSUE_TEMPLATE/release_checklist.md @@ -13,7 +13,7 @@ assignees: "" - [ ] License information is verified as correct. If you are unsure, please comment below. - [ ] Locally rendered documentation contains all appropriate pages, including API references (check no modules are missing), tutorials, and other human written text is up-to-date with any changes in the code. -- [ ] Installation instructions in the README, documentation and on the website (e.g., diffpy.org) are updated. +- [ ] Installation instructions in the README, documentation and on the website (e.g., diffpy.org) are updated. - [ ] Successfully run any tutorial examples or do functional testing with the latest Python version. - [ ] Grammar and writing quality are checked (no typos). @@ -21,7 +21,7 @@ Please mention @sbillinge here when you are ready for PyPI/GitHub release. Inclu ### PyPI/GitHub full-release preparation checklist: - [ ] Create a new conda environment and install the rc from pypi (`pip install =??`) -- [ ] License information at Pypi is verified as correct. +- [ ] License information at Pypi is verified as correct. - [ ] Docs deployed successfully to `.github.io` - [ ] Successfully run all tests, tutorial examples or do functional testing