validators.py created #282
Conversation
|
Warning! No news item is found for this PR. If this is a user-facing change/feature/fix, |
|
Great @lucas-lemos-da-silva We need to have a news file - Could you try to add a news file and i think we have the instruction provided? We also need to run pre-commit before making a PR, could you also do that, i think we also have that in the instruction. |
|
Also please refer to the "Lessons Learned" gitlab page on how to design commit msgs and PR titles |
There was a problem hiding this comment.
Thanks for this @lucas-lemos-da-silva
I think we maybe don't want validtaors.py inside parsers do we? It is a more boadly useful capability.
Also, I am not sure that isnumber() is really a validator per se. maybe we want to put it in to tools.py as a tool? We can discuss. @bobleesj?
The function seems to be called isnumber() but it is actually testing for whether the object can be converted to a float, not a number.
I think we maybe want to start with some tests and then we can work on the function.
I expect that this change in the code API will break things elsewhere too, so I would expect that there are likely other files that need to be updated. @lucas-lemos-da-silva do tests pass locally after this change?
|
Thank you for the comments! The current |
|
I will close this PR because I did not sync with the |
close #7 the module validators.py was created with the function isnumber. On the file loaddata.py the old "isfloat" was deleted. Please let me know if something is missing.