-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toggleOffOn breaks the configuration cache hack #2317
Comments
That spotless block wouldn't do anything, there must be some other configuration blocks hiding somewhere else... |
It must be the spotless block. I had added a workaround by excluding the file in question instead of using a toggle and that fixes the problem:
|
Ah, here is the problem, thanks for reporting it so clearly. spotless/lib/src/main/java/com/diffplug/spotless/generic/FenceStep.java Lines 140 to 145 in 3638f8f
It implements full roundtripping, but it does not implement the crazy equality hack that we did in This is fixable, but pretty tricky to fix. It will probably still be broken in |
We validate the cache ability of our elasticsearch build once on a regular basis. Testing updating spotless gradle plugin to 7.0.0BETA3(and 4) the cachabiltiy of one of the spotlessJava tasks within our build-tool-internal subproject is not cacheable due to
stepsInternalEquality
is reported to be different. I don't understand what causes this to be honest. it must be something special with the subproject. the only configuration there is using onOffToggle that we do not do in other places.Find attached a screenshot of our develocity check:
The text was updated successfully, but these errors were encountered: