-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of Flexmark or provide better defaults #2167
Labels
Comments
Changed defaults are not welcome (breaking change for existing users). But adding new parameters is welcome. Possible you can already cobble something together for this with one of the multiformatters like biome or prettier. |
liblit
added a commit
to liblit/WALA
that referenced
this issue
Jul 21, 2024
I would rather use Spotless for these checks, for consistency with other format checkers that we already use. Spotless supports Markdown via flexmark, but unfortunately [Spotless does not provide access to any of flexmark's configuration options](diffplug/spotless#2183). That would leave us with a Markdown linter that is too lenient for my tastes. For example, [Spotless's flexmark configuration does not even restrict maximum line length](diffplug/spotless#2167). Implements wala#818.
liblit
added a commit
to liblit/WALA
that referenced
this issue
Jul 21, 2024
I would rather use Spotless for these checks, for consistency with other format checkers that we already use. [Spotless supports Markdown via flexmark](https://github.com/diffplug/spotless/tree/main/plugin-gradle#flexmark), but unfortunately [Spotless does not provide access to any of flexmark's configuration options](diffplug/spotless#2183). That would leave us with a Markdown linter that is too lenient for my tastes. For example, [Spotless's flexmark configuration does not even restrict maximum line length](diffplug/spotless#2167). Resolves wala#818.
liblit
added a commit
to wala/WALA
that referenced
this issue
Jul 21, 2024
I would rather use Spotless for these checks, for consistency with other format checkers that we already use. [Spotless supports Markdown via flexmark](https://github.com/diffplug/spotless/tree/main/plugin-gradle#flexmark), but unfortunately [Spotless does not provide access to any of flexmark's configuration options](diffplug/spotless#2183). That would leave us with a Markdown linter that is too lenient for my tastes. For example, [Spotless's flexmark configuration does not even restrict maximum line length](diffplug/spotless#2167). Resolves #818.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The documentation says configuration options aren't available but the default configuration sets no limit for line length which kind of makes formatting markdown useless because each developer can make lines as long as they want.
The text was updated successfully, but these errors were encountered: