Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3: shard: Add Connect and Wait #337

Open
diamondburned opened this issue Aug 14, 2022 · 0 comments
Open

v3: shard: Add Connect and Wait #337

diamondburned opened this issue Aug 14, 2022 · 0 comments

Comments

@diamondburned
Copy link
Owner

diamondburned commented Aug 14, 2022 •
edited
Loading

As a follow-up to 258b614, shard.Manager should also implement these same methods. The current concern is that Manager keeps a state for each shard, all of which are guarded by a single mutex within Manager. This means that Wait running will prevent Close from working properly.

Ideally, Wait should not lock while it's running at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@diamondburned