You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Sometimes, when closing the final text box of a timeline using the same input which starts the timeline, Dialogic.current_timeline is not set back to null. (Or maybe briefly set to null then back to the timeline)
To Reproduce
Steps to reproduce the behavior:
Create a Godot project with Dialogic installed.
Create a Dialogic timeline with a single textbox.
Create a script which starts a timeline using the same input(s) as dialogic_default_action (Enter, LMB, Space, and/or X by default). Attach it to your root node.
Implement some way to view current_timeline. (e.g. printing it every frame)
Spam the key used to open/progress/close the timeline. Eventually current_timeline will have a value while no timeline is visible.
Expected behavior
When the timeline is not visible, Dialogic.current_timeline should equal null.
Screenshots
BEFORE TIMELINE
DURING TIMELINE
AFTER TIMELINE
My valid inputs for ui_accept are Enter and Space. This issue does not occur when advancing text with the X button or LMB.
System (please complete the following information):
OS: Windows 10
Godot Version: 4.2.2.stable.official
Dialogic Version: 2.0 alpha 16
Solutions
Workaround
For now I just ensure there are no overlapping inputs for ui_accept and dialogic_default_action however it's very awkward. I will probably create and update a manual flag which marks ongoing dialgoue.
Possible fixes
Unsure.
The text was updated successfully, but these errors were encountered:
The problem
Describe the bug
Sometimes, when closing the final text box of a timeline using the same input which starts the timeline, Dialogic.current_timeline is not set back to null. (Or maybe briefly set to null then back to the timeline)
To Reproduce
Steps to reproduce the behavior:
Expected behavior
When the timeline is not visible, Dialogic.current_timeline should equal null.
Screenshots
BEFORE TIMELINE
DURING TIMELINE
AFTER TIMELINE
My valid inputs for ui_accept are Enter and Space. This issue does not occur when advancing text with the X button or LMB.
System (please complete the following information):
Solutions
Workaround
For now I just ensure there are no overlapping inputs for ui_accept and dialogic_default_action however it's very awkward. I will probably create and update a manual flag which marks ongoing dialgoue.
Possible fixes
Unsure.
The text was updated successfully, but these errors were encountered: