-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terraform-apply status check #169
Comments
Hi @JafoFett, you should be able to select whatever the apply job is as a required status check. This would require that the apply job was triggered and ran successfully at least once before the PR can be merged. |
That's what I thought too, but if I put the terraform-apply job as a required check in the branch protection the pr does not actually put that as a status, so it sits there waiting for it. Unless i'm missing something... |
It seems using issue_comment for manual triggers might be the issue here, doesn't seem to create a status check. |
Suggestion
Would it be possible to have the terraform apply on comment create a status? Would like my repo to be un-mergeable until the terraform-apply completes with success, then after that the repo could accept a merge to main after the status check completes.
The text was updated successfully, but these errors were encountered: