New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mac OS port] Potential issues with keyboard modifier state #19
Comments
See answer in #18 . |
@dfeneyrou What are your thoughts on adding this? https://github.com/dfeneyrou/palanteer/pull/21/files#diff-2d88bc2cf5369b76a592e61c044242925375802ffdcbcbf8440711355359fe76R695-R707 And do you think it makes sense to add something like
to all of the |
In my MacOS port, I've been noticing issues where the application didn't realize I was holding down certain modifier keys.
I believe the cause is that the modifier state isn't being appropriately synchronized here: https://github.com/dfeneyrou/palanteer/blob/main/server/viewer/vwPlatform.cpp#L642-L718
Note that the
kms
parameter is ignored in many of the functions in the file, which can lead to these imgui fields not being synchronized to the keyboard state correctly:I also haven't been able to determine which
osHandler->event*
function would be best to call when responding to theNSEventTypeFlagsChanged
event type on macOS. See https://github.com/ocornut/imgui/blob/0b8a2470743f89d19ab2d5920606434b604b529e/backends/imgui_impl_osx.mm#L342-L345 for how it is handled in the Dear ImGui example.The text was updated successfully, but these errors were encountered: