Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLMatcher.match incorrectly matches <path:_> #109

Open
RolandasRazma opened this issue Oct 5, 2018 · 2 comments
Open

URLMatcher.match incorrectly matches <path:_> #109

RolandasRazma opened this issue Oct 5, 2018 · 2 comments

Comments

@RolandasRazma
Copy link
Contributor

RolandasRazma commented Oct 5, 2018 •
edited

URLMatcher.match incorrectly matches empty url's. If you pass "" to match it will return wildcard paths

for example:

"" will match "/anything/<path:_>"
"/anything" will match "/anything/<path:_>" and is incorrect as patch is /anything/* not /anything*

normalizeURL normalizes "/" to "" - not sure if thats intended behaviour
@RolandasRazma RolandasRazma changed the title URLMatcher.match incorrectly matches empty url's URLMatcher.match incorrectly matches <path:_> Oct 15, 2018
@RolandasRazma RolandasRazma mentioned this issue Dec 24, 2018
Merged
@RolandasRazma
Copy link
Contributor Author

created failing tests pr

@RolandasRazma
Copy link
Contributor Author

also added fix.

this is not complete fix. it DOES make all test pass but it doesn't fix underlaying problem

devxoul added a commit that referenced this issue Mar 29, 2019
@devxoul
Merge pull request #117 from getfiit/issues-109_tests
c7d9092 
issue #109 tests & fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RolandasRazma