Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not allow https connections when DevSpace Cloud is deployed with http-only configuration #10

Open
LukasGentele opened this issue Sep 27, 2019 · 0 comments

Comments

@LukasGentele
Copy link

Currently, https connections are allowed even when DevSpace Cloud is deployed as http-only and this leads to issues with the session storage. If the users logs in via https and adds DevSpace Cloud as provider via devspace add provider --host=http://... using http, the CLI will open the login page because the user is not authenticated because the authentication is limited to the https version.

  1. If HTTPS is configured, requests should always be forwarded to HTTP (but NON-permanent redirect, so status code 307 instead of 301 because otherwise switching the protocol will never be possible due to infinite browser caching of 301 redirects).
  2. If HTTP is configured, requests to HTTPS should not be accepted or forwarded as 307 to HTTP as well. However, it is important that the ingress controller itself is accepting HTTPS requests, e.g. for space domains etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant