-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contact form added #37
base: vue
Are you sure you want to change the base?
Conversation
@samarth-1729 Always add screenshots in the description when you add/improve UI |
URL is modified |
contact button added in footer |
src/views/AboutUs.vue
Outdated
counter=true | ||
v-model="mobileNo" | ||
:rules="numberRules") | ||
div.form-row(name="inputSuggestion") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
src/views/AboutUs.vue
Outdated
max-height: 300px; | ||
max-width: 400px; | ||
margin-top: 40px; | ||
border-radius: 20px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant style
src/components/Footer.vue
Outdated
v-col.py-4.text-center.white--text.font-weight-bold(color="secondary" cols="12") {{ new Date().getFullYear() }} — Devlup Labs | ||
v-col.my-n5.text-center.font-weight-bold(color="secondary" cols="12") | ||
v-btn.text-center.white--text.font-weight-bold(text='Primary', | ||
to='./about', color='white' large |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use relative links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually dont use the button it stays active when on the about us page, use plain text as the link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p.s. no need to add commas
src/components/Footer.vue
Outdated
v-icon {{link.icon}} | ||
v-col.py-4.text-center.white--text.font-weight-bold(color="secondary" cols="12") {{ new Date().getFullYear() }} — Devlup Labs | ||
v-col.my-n5.text-center.font-weight-bold(color="secondary" cols="12") | ||
v-btn.text-center.white--text.font-weight-bold(text='Primary', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does text=Primary
do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without it button is looking completly while
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
white?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samarth-1729 you mean the text
prop adds color to the button?
@Sandesh1013 I have noticed a few of console errors please
|
v-icon {{link.icon}} | ||
v-col.py-4.text-center.white--text.font-weight-bold(color="secondary" cols="12") {{ new Date().getFullYear() }} — Devlup Labs | ||
v-col.my-n5.text-center.font-weight-bold(color="secondary" cols="12") | ||
v-btn.text-center.white--text.font-weight-bold(text='Primary' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is text='Primary'
necessary? what does it do?
@@ -46,8 +46,8 @@ v-container(fluid='' style='margin: 0px; padding: 0px; width: 100%;') | |||
div.container.col-sm-10(class="my-5" name="") | |||
v-row(class="no-gutters pb-5" id="formRow") | |||
div.col-md-5(class="pt-11 pl-7 pb-0" align="center" justify="center") | |||
v-img.img-fluid.mt-10(src="../assets/contactUs.png" | |||
max-height='300' max-width='400' | |||
v-img.img-fluid.mt-40(src="../assets/contactUs.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
margin does not have sizes more than 16 in vuetify, why 40?
The contact form has been added in the about us page