Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orientation incorrectly reported as portrait #410

Closed
GeorgeElsham opened this issue May 1, 2024 · 1 comment · Fixed by #411
Closed

Orientation incorrectly reported as portrait #410

GeorgeElsham opened this issue May 1, 2024 · 1 comment · Fixed by #411

Comments

@GeorgeElsham
Copy link
Contributor

In some cases when the orientation is neither landscape nor portrait, the reported orientation from orientation is .portrait. The orientation can be neither in some cases such as during Xcode previews after a reload when the device is already in landscape, though that also seems like a bug in Xcode previews reporting the wrong orientation.

This issue is caused by only checking if the orientation is landscape or not:

public var orientation: Orientation {
if UIDevice.current.orientation.isLandscape {
return .landscape
} else {
return .portrait
}
}

I would expect an .unknown orientation variant. This can be a breaking change, however, I would say a minor version bump is fine because:

  1. If not checking with switch, the user doesn't care about other possible variants, and so this code won't affect them
  2. If checking with switch, Xcode will give a compiler error, and is a very quick fix
@GeorgeElsham
Copy link
Contributor Author

FWIW, I've filed feedback with Apple about the Xcode canvas issue, public copy here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant