From 7c67df198dc17f3957cfe1ed79a1381c0dc24c88 Mon Sep 17 00:00:00 2001
From: Development for People
 <47140294+developmentforpeople@users.noreply.github.com>
Date: Sun, 3 Mar 2024 09:25:07 +0000
Subject: [PATCH] FIX issue #19, duplicated file names were using same S3 key
 and overriden. Solved including file id within key

---
 .../doctype/dfp_external_storage/dfp_external_storage.py       | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dfp_external_storage/dfp_external_storage/doctype/dfp_external_storage/dfp_external_storage.py b/dfp_external_storage/dfp_external_storage/doctype/dfp_external_storage/dfp_external_storage.py
index 2ee14fd..400cb55 100644
--- a/dfp_external_storage/dfp_external_storage/doctype/dfp_external_storage/dfp_external_storage.py
+++ b/dfp_external_storage/dfp_external_storage/doctype/dfp_external_storage/dfp_external_storage.py
@@ -373,8 +373,11 @@ def dfp_external_storage_upload_file(self, local_file=None, delete_file=True):
 
 		# TODO: MOSTRAR MENSAJE DE SUBIENDO ARCHIVO Y CERRARLO O MOSTRAR ARCHIVO SUBIDO AL FINAL DE ESTE MÉTODO
 
+		# Define S3 key
+		# key = f"{frappe.local.site}/{self.file_name}" # << Before 2024.03.03
 		base, extension = os.path.splitext(self.file_name)
 		key = f"{frappe.local.site}/{base}-{self.name}{extension}"
+
 		is_public = "/public" if not self.is_private else ""
 		if not local_file:
 			local_file = "./" + frappe.local.site + is_public + self.file_url