-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support innerHTML in serialization recipe #7
Comments
Ah - good call, the serializer should at least support One benefit of this would be that we could take your solution and bundle it in as a |
This was referenced Apr 3, 2017
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I understand you don't want to support serialization in this project which makes sense. However, when experimenting with the example recipe I've noticed an issue when serializing the document after Preact mutates it. I end up with elements that have both innerHTML and childNodes[] defined. The innerHTML value seems to have not been cleaned up. I'm not sure where or why this is happening exactly. Any thoughts?
I've added innerHTML and void elements to my implementation here: https://gist.github.com/Stanback/3bb0b19b299668ce0e08922a8ab6876e
The text was updated successfully, but these errors were encountered: