-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NodeList #34
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tried using this for a unit-test, and ran into some issues with e.g.
childNodes
, which in regular DOM is a NodeList and not just anArray
, which is missing, for example, thekeys()
,values()
andentries()
iterator methods.I can foresee issues as well with e.g.
children
being a plainArray
created by filteringchildNodes
- whereas, in regular DOM, mutating thechildNodes
of the parent that generated thechildren
collection, would cause the iterator to reflect those changes.Maybe this is "by design", favoring simplicity over correctness?
If so, that isn't clear from the "Project Goals" stated in the README right now - it doesn't seem to imply that this deviates from DOM in terms of more than features.
Lacking features is a matter of scope - but incompatibilities probably ought to be designated in the documentation?
The text was updated successfully, but these errors were encountered: