-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releasing thread and URL reference when the workerized function is not needed #49
Comments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Great library, very useful stuff and absolutely love the size. :)
I've only recently started learning about
Web Workers
and took a look at the source code. So apologies in advance if I am wrong ;). 2 things caught my eyes:So if we do something like the following snippet (taken from the README), it seems that each new function instantiated via
greenlet(...)
will reserve a new thread and a new URL reference.So, if there is a case wherein I don't need to use
getName
after a certain point in my code, those resources are still trapped. They may be very less in size to be of a practical concern, but I am not sure about it and would love if anyone can comment on that.However, if the output function
getName
comes with adispose
method which releases those references, it could be useful. WDYT? Something like:Internally, it could call:
Post
dispose
,getName
can itself becomeundefined
so it's not callable. Or canthrow
a more informative error:The function is disposed/discarded due to .dispose() call.
.Is there a downside to this approach if the contributors already considered any similar approach?
The text was updated successfully, but these errors were encountered: