Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if a "frontend" command exist during installation #25

Closed
dermatz opened this issue Jul 1, 2024 · 4 comments
Closed

Warn if a "frontend" command exist during installation #25

dermatz opened this issue Jul 1, 2024 · 4 comments
Assignees
Milestone

Comments

@dermatz
Copy link
Owner

dermatz commented Jul 1, 2024

Could not run/install command ddev frontend init if "frontend" command already exists.

@dermatz dermatz changed the title Install if frotnend command exist Install if frontend command exist Jul 1, 2024
@Morgy93 Morgy93 self-assigned this Jul 1, 2024
@Morgy93
Copy link
Collaborator

Morgy93 commented Jul 1, 2024

It throws the error:

NOT overwriting .ddev/commands/web/frontend.
The #ddev-generated signature was not found in the file, so it will not be overwritten.
You can remove the file and use DDEV get again if you want it to be replaced: signature was not found in file .ddev/commands/web/frontend 

So it's by design and I think we should not interfere with it. 😕

@rfay
Copy link

rfay commented Jul 1, 2024

Apparently the frontend has been modified by the user, since the original has #ddev-generated in it:

https://github.com/dermatz/ddev-woodoo-buildtools-magento/blob/main/commands/web/frontend#L2

So if you don't care about the modifications, just remove that file and a ddev get will work without errors.

@dermatz
Copy link
Owner Author

dermatz commented Jul 24, 2024

In the agency environment, it has happened now and again that some developers have built their own frontend command, which now clashes with ours. So my plan is to check in advance and tell the user that such a file exists and to overwrite it directly if necessary, even if there is no #ddev-generated.

@dermatz dermatz added this to the 1.7.0 milestone Jul 24, 2024
@dermatz dermatz added the under investigation This Task is under investigation label Jul 24, 2024
@dermatz dermatz modified the milestones: 1.7.0, 1.8.0 Aug 6, 2024
@dermatz dermatz changed the title Install if frontend command exist Warn if a "frontend" command exist during installation Aug 6, 2024
@dermatz dermatz added the in progress will be released in next release label Aug 6, 2024
dermatz added a commit that referenced this issue Aug 11, 2024
- Remove existing `frontend` command to install Woodoo correctly
- Add replace notification in `README.md` if frontend command exists in `.ddev/commands/web/frontend`
- Add post-installation action with relevant next steps notifications

Fixes #35
@dermatz dermatz added in code-review and removed under investigation This Task is under investigation labels Aug 11, 2024
@dermatz
Copy link
Owner Author

dermatz commented Aug 11, 2024

It throws the error:

NOT overwriting .ddev/commands/web/frontend.
The #ddev-generated signature was not found in the file, so it will not be overwritten.
You can remove the file and use DDEV get again if you want it to be replaced: signature was not found in file .ddev/commands/web/frontend 

So it's by design and I think we should not interfere with it. 😕

Yes, I'm fine with that. All needed information about the case are given during the installation.
The user just needs to use his eyes.

I will close this ticket and PR right now.

@dermatz dermatz closed this as completed Aug 11, 2024
@dermatz dermatz added will not be implemented and removed in progress will be released in next release in code-review labels Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants