Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileHandle missing methods #25554

Open
14 of 24 tasks
kt3k opened this issue Sep 10, 2024 · 3 comments
Open
14 of 24 tasks

FileHandle missing methods #25554

kt3k opened this issue Sep 10, 2024 · 3 comments
Labels
bug Something isn't working correctly good first issue Good for newcomers node compat

Comments

@kt3k
Copy link
Member

kt3k commented Sep 10, 2024

FileHandle class (in node:fs/promises) still misses the below methods:

ref: https://nodejs.org/api/fs.html#class-filehandle

Originally posted by @k-nasa in #19165 (comment)

@kt3k kt3k added bug Something isn't working correctly node compat labels Sep 10, 2024
@kt3k kt3k added the good first issue Good for newcomers label Nov 25, 2024
marvinhagemeister pushed a commit that referenced this issue Jan 7, 2025
Add the chmod method to the FileHandle class in node compat as part of
#25554
dsherret pushed a commit that referenced this issue Jan 9, 2025
Add the chmod method to the FileHandle class in node compat as part of
#25554
@obafemitayor
Copy link

@kt3k Can I work on this?

@kt3k
Copy link
Member Author

kt3k commented Jan 14, 2025

Yes please

@kt3k
Copy link
Member Author

kt3k commented Jan 14, 2025

Note to contributors: Please read the Node.js source code of FileHandle class first (you can find it here https://github.com/nodejs/node/blob/main/lib/internal/fs/promises.js) and make the implementation as close as possible to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly good first issue Good for newcomers node compat
Projects
None yet
Development

No branches or pull requests

2 participants