Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize accepting not yet existing contacts #6259

Open
link2xt opened this issue Nov 24, 2024 · 1 comment · May be fixed by #6277
Open

Synchronize accepting not yet existing contacts #6259

link2xt opened this issue Nov 24, 2024 · 1 comment · May be fixed by #6277
Assignees
@iequidoo
Labels
bug Something is not working

Comments

@link2xt
Copy link
Collaborator

link2xt commented Nov 24, 2024

Synchronization message for accepting or blocking a contact 1:1 chat may arrive before the first message, when the contact does not exist yet. This frequently happens in non-chatmail accounts that have moving to DeltaChat folder disabled because Delta Chat unconditionally uploads sync messages to DeltaChat folder (even over IMAP since #5901 is merged).

For chats identified by SyncId::ContactAddr, if contact does not exist yet Delta Chat should create a hidden contact and hidden (blocked) 1:1 chat, then accept it.

Handling group chats and even blocking is outside of the scope for the issue, this can be closed once Delta Chat handles reception of accept sync item for not yet existing 1:1 chat as it is the most common case.

This issue is similar to #5954
@link2xt link2xt added the bug Something is not working label Nov 24, 2024
@iequidoo iequidoo self-assigned this Nov 27, 2024
iequidoo added a commit that referenced this issue Nov 29, 2024
@iequidoo
fix: Sync chat action even if sync message arrives before first one f…
b2f5c55 
…rom contact (#6259)

A sync message for accepting or blocking a 1:1 chat may arrive before the first message from the
contact, when it does not exist yet. This frequently happens in non-chatmail accounts that have
moving to the DeltaChat folder disabled because Delta Chat unconditionally uploads sync messages to
the DeltaChat folder. Let's create a hidden contact in this case and a 1:1 chat for it.
@iequidoo iequidoo linked a pull request Nov 29, 2024 that will close this issue
Open
@iequidoo
Copy link
Collaborator

iequidoo commented Nov 29, 2024 •
edited
Loading

Made a fix, the only difference is that i create a Blocked::Request 1:1 chat, this doesn't matter if things go on normally, but e.g. if the program crashes, it's easier for the user to find the chat and accept/block it.

iequidoo added a commit that referenced this issue Nov 30, 2024
@iequidoo
fix: Sync chat action even if sync message arrives before first one f…
b5b8f5d 
…rom contact (#6259)

A sync message for accepting or blocking a 1:1 chat may arrive before the first message from the
contact, when it does not exist yet. This frequently happens in non-chatmail accounts that have
moving to the DeltaChat folder disabled because Delta Chat unconditionally uploads sync messages to
the DeltaChat folder. Let's create a hidden contact in this case and a 1:1 chat for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iequidoo iequidoo

Labels
bug Something is not working
Projects
None yet
Milestone
No milestone
2 participants
@link2xt @iequidoo