-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove s3_cli module from test_utils #1558
Comments
Hey @rtyler, I started taking a look at this issue and I'm wondering if it's going in the right direction with my draft PR #1570. For now just creating the bucket with rusoto_s3 using their async API, but it required me to make a lot more functions async as well. Is that an issue? Or is there perhaps a better way of doing it? Curious for your feedback! Edit: 0f015aa uses |
In
rust/src/test_utils.rs
we have some shell invocations of the AWS cli which aren't necessary (IMHO) because we can do all of these operations directly from Rusoto without adding the system dependency.The text was updated successfully, but these errors were encountered: