Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack anyone in a channel can deploy #33

Open
colinjfw opened this issue Nov 28, 2019 · 1 comment
Open

Slack anyone in a channel can deploy #33

colinjfw opened this issue Nov 28, 2019 · 1 comment

Comments

@colinjfw
Copy link
Collaborator

Currently the Slack integration involves using a slash command as that has less in terms of permissions required that users give up. It also ties an individual Slack user to a GitHub user thereby deploying using personal GitHub credentials and therefore GitHub's permissions.

The suggestion here is to change this so that when I invite Deliverybot to my #deployments channel anyone in that channel can say @deliverybot deploy this branch. This would be using Slack as the source of truth around permissions.

This may end up being an entirely different Slack app if implemented. This ticket needs feedback!
@jbergstroem
Copy link

This may end up being an entirely different Slack app if implemented. This ticket needs feedback!

Perhaps map to github teams to channels somehow? @acmeco/devops can deploy, etc?

@colinjfw colinjfw transferred this issue from another repository Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbergstroem @colinjfw