Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterized deployment support #27

Open
colinjfw opened this issue Jan 30, 2020 · 3 comments
Open

Parameterized deployment support #27

colinjfw opened this issue Jan 30, 2020 · 3 comments

Comments

@colinjfw
Copy link
Collaborator

Allow deploying with variables that can be interpolated into the payload of the deployment. Similar to parameterized builds in Jenkins.

@colinjfw colinjfw transferred this issue from another repository Feb 20, 2020
@colinjfw colinjfw removed this from In progress in Roadmap Feb 20, 2020
@jbergstroem
Copy link

jbergstroem commented Mar 2, 2020

Reading from a file in repo would be awfully convenient as well (that can be overwritten via the parameterized deploy).

Our use case are variables per environment that doesn't necessarily have to be classified as a github secret.

@missedone
Copy link

missedone commented May 10, 2020

github slackbot support pass in the deployment payload: https://github.com/integrations/slack

however i'm looking for the same feature as well in deliverybot since i want to trigger the deployment either with slack or the web gui

thanks

@missedone
Copy link

missedone commented Jul 12, 2020

ok, we can implement parameterize build with payload: https://deliverybot.dev/docs/configuration/#targetpayload

but noticed that the payload format is different with github slack.
deliverybot defines the payload as object (aka, JSON/Yaml object), while github slack is just raw string, it's inconsistent.
i'd suggest to support raw json string to be consistent with slack, Example:

prefer

production:
  environment: production
  production_environment: true
  payload: |
    {"foor": "bar"}

over

production:
  environment: production
  production_environment: true
  payload: 
    foo: bar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants