-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
shouldOverrideUrlLoading does not seem to get called properly + appreciation post #279
Comments
Thanks! If you have added a restricted set of allowed hostnames, either via Other than that, when you set up a custom But, I鈥檓 afraid you might have to override the variant of (If this works, this aspect should really be fixed or documented. Sorry for that!) |
Thanks for your response @ocram ! Indeed, overriding Thanks again for your good work 馃憣 |
Reopening until fixed. Thanks again! |
First off, thanks so much for this project! 馃檹
Saved me lots of time - wish I knew about this before ^^
During implementation of your library, I found a small problem (might as well be on my side)
When registering a
WebViewClient()
like this, I would normally expect theshouldOverrideUrlLoading
function to be called.Expected
wv?.loadUrl()
) theshouldOverrideUrlLoading
function should be calledurl-triggered
should be loggedreturn true
Actual
shouldOverrideUrlLoading
is not called; noting is loggedPossibility to Avoid this / get the expected behaviour
I would not call this a clean approach, but it works 馃檮
onPageStarted
wv?.stopLoading()
wv?.onBackPressed()
The text was updated successfully, but these errors were encountered: