Updates (particularly for spdx-correct and spdx-satisfies) #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucturing, no useless else, line breaks in destructured params, prefer spread) - Linting (ESLint): Add ignore file in conjunction with linting all by default (catches index.js) - npm: Update eslinting devDeps to latest major versions - npm: Update spdx-correct, and spdx-satisfies to latest major versions - npm: Update other deps. to latest minor version - Travis: Update per newest minimum (and add 10 and 12)
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes here are the major version bumps for
spdx-correctandspdx-satisfies.For
spdx-correct, the major bump occurred with updates to:spdx-license-ids(which moved out some now deprecated licenses): jslicense/spdx-license-ids@b9f544d and changes to the IDS per a new build: https://github.com/shinnn/spdx-license-ids/pull/8/files . I think this is reasonable unless you wanted to allow checking against deprecated licenses.spdx-expression-parsewhich also updated itsspdx-license-idsbut used them to determine validity. I think the advantage of supporting any newer types outweighs and disadvantages of missing any older types. It also updatedspdx-exceptionsbut this was a minor change and looking at the source, it doesn't appear it should affect anything.As far as
spdx-satisfies, it has incremented several major versions, updating its copy ofspdx-correct. You'd have to go through the other changes if you want an exact picture, but the API of passing two arguments is still the same, and I expect it should be doing better than before at checking whether the expressions satisfy the license criteria.The other updates just need assuming that the minor/patch versions are ok, and assuming you are ok with moving to Node 8.3 (I know Travis is 8, but the spread syntax recommended now by airbnb requires 8.3, and Node 8 just entered EOL anyways, so really should upgrade to 10), I think these changes should all be good. (Without existing tests, it is harder to know, but as per the above, I have tried to ascertain the safety of these changes. I am using my fork and it has fixed #21 for me with
getLicenseType.)