Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tangent vector handedness #8733

Open
Jhonnyg opened this issue Mar 28, 2024 · 0 comments · May be fixed by #8871
Open

Support tangent vector handedness #8733

Jhonnyg opened this issue Mar 28, 2024 · 0 comments · May be fixed by #8871
Assignees
Labels
bug Something is not working as expected engine Issues related to the Defold engine task A task that needs to be performed

Comments

@Jhonnyg
Copy link
Contributor

Jhonnyg commented Mar 28, 2024

Task (REQUIRED):
Right now we export tangents from modelc as vec3s and then derive bitangents from the normal and the tangent, meaning we have no way of knowing if the tangent coordinate system is correct or not. A typical solution, if we don't want to export bitangents, is to pack the handedness direction in the .w component of the tangent vector, which can then be used to multiple the bitangent vector with after the derivation in the shader. Blender exports tangents in this way (and I think most do), so it should be a simple improvement.

Expected outcome (REQUIRED):
Describe the expected outcome of the task (new issue, documentation, code change etc)

@Jhonnyg Jhonnyg added task A task that needs to be performed bug Something is not working as expected labels Mar 28, 2024
@matgis matgis added the engine Issues related to the Defold engine label Apr 2, 2024
@Jhonnyg Jhonnyg linked a pull request Apr 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as expected engine Issues related to the Defold engine task A task that needs to be performed
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants