Strictgin error handler #1600
Open
Strictgin error handler #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamietanna
reviewed
Jun 1, 2024
| @@ -34,19 +47,18 @@ type strictHandler struct { | |||
| {{if .IsJSON }} | |||
| var body {{$opid}}{{.NameTag}}RequestBody | |||
| if err := ctx.ShouldBindJSON(&body); err != nil { | |||
| ctx.Status(http.StatusBadRequest) | |||
| ctx.Error(err) | |||
| sh.options.ErrorHandlerFunc(ctx, err) | |||
There was a problem hiding this comment.
should this not still be sending a http.StatusBadRequest?
jamietanna
reviewed
Jun 1, 2024
| return | ||
| } else if boundary := params["boundary"]; boundary == "" { | ||
| ctx.Error(http.ErrMissingBoundary) | ||
| sh.options.ErrorHandlerFunc(ctx, err) |
There was a problem hiding this comment.
should this not still be sending a http.ErrMissingBoundary?
jamietanna
reviewed
Jun 1, 2024
| @@ -93,14 +105,13 @@ type strictHandler struct { | |||
| response, err := handler(ctx, request) | |||
|
|
|||
| if err != nil { | |||
| ctx.Error(err) | |||
| ctx.Status(http.StatusInternalServerError) | |||
| sh.options.ErrorHandlerFunc(ctx, err) | |||
There was a problem hiding this comment.
should this not still be sending a http.StatusInternalServerError?
jamietanna
reviewed
Jun 1, 2024
| } | ||
| } else if response != nil { | ||
| ctx.Error(fmt.Errorf("unexpected response type: %T", response)) | ||
| sh.options.ErrorHandlerFunc(ctx, err) |
There was a problem hiding this comment.
Suggested change
| sh.options.ErrorHandlerFunc(ctx, err) | |
| sh.options.ErrorHandlerFunc(ctx, fmt.Errorf("unexpected response type: %T", response)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strict gin server doesn't currently use an error handler function. This adds the error handler to the strict gin handler