-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.124.0 of kin-openapi introduces compilation errors #1533
Labels
Milestone
Comments
jamietanna
added
dependencies
Pull requests that update a dependency file
upstream
labels
Apr 8, 2024
Note that this will also require us bumping the middlewares, as each of them need to also be at a compatible |
pascalPost
pushed a commit
to pascalPost/campaign-manager
that referenced
this issue
May 20, 2024
kin-openapi cannot be updated right now, b.c. of an incompatibility with oapi-codegen, see oapi-codegen/oapi-codegen#1533
7 tasks
jamietanna
pushed a commit
that referenced
this issue
Jun 3, 2024
Note that, as noted in #1533, this version introduces a significant breaking changes, which requires us make code changes. The key change introduced is that we now have a `Types` type, which supports how in OpenAPI 3.1 (and JSON Schema proper) there can be multiple types. Note that we do not add the support for full OpenAPI 3.1 specifications (#373) and make sure that we only use the `.Is` call, which makes sure it's the 0th element, so we don't accidentally start to have OpenAPI 3.1 support before we're ready for it. Closes #1533.
jamietanna
pushed a commit
that referenced
this issue
Jun 3, 2024
Note that, as noted in #1533, this version introduces a significant breaking changes, which requires us make code changes. The key change introduced is that we now have a `Types` type, which supports how in OpenAPI 3.1 (and JSON Schema proper) there can be multiple types. In cases where previously we'd receive a Type of `""`, we now receive a nil array, so we need to validate that with the `.Slice()` method. Note that we do not add the support for full OpenAPI 3.1 specifications (#373) and make sure that we only use the `.Is` call, which makes sure it's the 0th element, so we don't accidentally start to have OpenAPI 3.1 support before we're ready for it. Closes #1533.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As seen in #1532
Raising this for an FYI for anyone who may see errors like the below in their own builds when updating
kin-openapi
:Absolutely fair for them to do this, as is their right in a pre-v1 release.
This will be fixed by the next release, but in the meantime, it may be worth not upgrading kin-openapi if you can avoid it, or once #1532 is merged, pin to HEAD.
The text was updated successfully, but these errors were encountered: