Change of behaviour in 1.4.1

[replabrobin]

After a recent update I ran some tests of third party code which we use and find that I'm getting errors related to NodeTracker which I guess is a change to the ElementWrapper that has converted to cssselect2.ElementWrapper.

A simple example would be a test we have of the cubic_bezier conversion

from svglib import svglib
from lxml import etree
def parseXML(s):
	return etree.XML(s)
node = svglib.NodeTracker(parseXML(
		'<path d="M3,4c-0.5-0.25-1.3-0.77-1.3-1.8h2.5s0.04,0.46,0.04,1.48z"/>'
	))

this fails with an error

ERROR: test_cubic_bezier_shorthand (__main__.TestPaths)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "REPOS/rlextra/tests/thirdparty/test_svg_basic.py", line 130, in test_cubic_bezier_shorthand
    '<path d="M3,4c-0.5-0.25-1.3-0.77-1.3-1.8h2.5s0.04,0.46,0.04,1.48z"/>'
  File "/home/robin/devel/test-code/rl-testing/.py37/lib/python3.7/site-packages/svglib/svglib.py", line 429, in __init__
    super().__init__(*args, **kwargs)
TypeError: __init__() missing 4 required positional arguments: 'parent', 'index', 'previous', and 'in_html_document'

I also see some changes to space preservation; this code is an example

if __name__=="__main__":
	from svglib import svglib
	import io, textwrap
	xml = textwrap.dedent(u'''\
			<?xml version="1.0"?>
			<svg width="777" height="267">
			  <text style="fill:#000000; stroke:none; font-size:28;">
				<tspan>TITLE	1</tspan>
				<tspan x="-10.761" y="33.487">Subtitle</tspan>
			  </text>
			</svg>
		''')
	print(xml)
	drawing = svglib.svg2rlg(io.StringIO(xml))
	print(repr([s.text for s in drawing.contents[0].contents[0].contents]))

in 1.3.0 this produces

<?xml version="1.0"?>
<svg width="777" height="267">
  <text style="fill:#000000; stroke:none; font-size:28;">
    <tspan>TITLE    1</tspan>
    <tspan x="-10.761" y="33.487">Subtitle</tspan>
  </text>
</svg>

['TITLE 1', 'Subtitle']

and in 1.4.1 I see

<?xml version="1.0"?>
<svg width="777" height="267">
  <text style="fill:#000000; stroke:none; font-size:28;">
	<tspan>TITLE	1</tspan>
	<tspan x="-10.761" y="33.487">Subtitle</tspan>
  </text>
</svg>

['TITLE 1', ' ', 'Subtitle']

my question is why we see the extra ' ' in between the text from the two tspans. I'm not expert on the semantics of svg tag, but are we saying that leading/trailing whitespace is ignored and some interior whitespace is converted to simple spaces (ie we ignore the actual linefeeds)? Acording to https://www.w3.org/TR/xml/#sec-white-space either all whitespace should be preserved or some could be (if xml:space has value default). I have some other errors, but would appreciate more expert opinions on how I should proceed to modify/fix tests like these.

[replabrobin]

I find these errors are just caused by an old copy of the svglib tests which we used to embed in our jumbo package. Assuming the latest svglib tests work is probably the right thing to do and I can remove the old ones.