Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better cache busting #1109

Open
ethteck opened this issue Mar 5, 2024 · 6 comments
Open

Better cache busting #1109

ethteck opened this issue Mar 5, 2024 · 6 comments
Labels
bug Unintended behaviour frontend

Comments

@ethteck
Copy link
Member

ethteck commented Mar 5, 2024

When we update certain things like the recent #1103 , it breaks the site because the browser cache doesn't play well with the new state of things

@ethteck ethteck added bug Unintended behaviour frontend labels Mar 5, 2024
@bates64
Copy link
Member

bates64 commented Mar 5, 2024

vercel deploys would fix this plobably

@ethteck
Copy link
Member Author

ethteck commented Mar 5, 2024

I'm sure there's an elegant solution that wouldn't require using vercel. I would rather we go for a simple fix for this issue

@bates64
Copy link
Member

bates64 commented Mar 5, 2024

yeah, i just maintain that vercel would give us lots of other nice benefits too

@bates64
Copy link
Member

bates64 commented Mar 5, 2024

as vercel want me to think obviously so they can make their investors happy but its free so

@ethteck ethteck added the backend label Mar 5, 2024
@ethteck
Copy link
Member Author

ethteck commented Mar 5, 2024

I think I've found one of the issues... /api/compiler is returning a 304. Once I manually loaded this endpoint, I stopped getting errors. adding the backend tag too

@ethteck
Copy link
Member Author

ethteck commented Mar 5, 2024

I think last_modified_funcs should add in when the backend launched: https://github.com/decompme/decomp.me/blob/main/backend/coreapp/views/compiler.py#L40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unintended behaviour frontend
Projects
None yet
Development

No branches or pull requests

2 participants