New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlogRoll not using "count" property #844
Comments
Interesting @SalazarJosh! So you'd like the count to be used to return back how many blog posts you'd want to get back? In my mind I was thinking this count would be only a read only to give back the total number of blog posts that we have. I think given that we're not using it, it might be be better for us to remove it. We could use the
|
Feature request
What is the expected behavior?
The BlogRoll has a count property that doesn't look to be implemented.
What is motivation or use case for adding/changing the behavior?
We should be able to use this count property to determine the number of blog posts to return. For example, I have a "latest from the blog" section that only shows the latest 3 blog posts.
How should this be implemented in your opinion?
The BlogRoll component should receive props and pass that to the BlogRollTemplate. That count can be used to slice the initial data or as part of the .map() function.
I'm doing the latter with a ternary operator to keep the count property optional.
{posts && posts.slice(0, (this.props.count != undefined ? this.props.count : this.props.data.length)).map(({ node: post }) => { ... }
Are you willing to work on this yourself?
yes
The text was updated successfully, but these errors were encountered: