Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naming convention #71

Open
juice500ml opened this issue Feb 15, 2017 · 11 comments
Open

naming convention #71

juice500ml opened this issue Feb 15, 2017 · 11 comments
Assignees

Comments

@juice500ml
Copy link
Member

juice500ml commented Feb 15, 2017

get/set --> remote/local
camel / underscore / hypen

@minhoryang
Copy link
Member

Flake8 please

@punkyoon
Copy link
Member

punkyoon commented Feb 26, 2017

09c0697

travis에서 확인할 수 있게 해두었어요.. 차근차근 고쳐볼게요!

@juice500ml
Copy link
Member Author

https://git-scm.com/book/ko/v1/Git%EB%A7%9E%EC%B6%A4-Git-%ED%9B%85
travis 말고 git hook이 낫지 않을까싶습니다!

@juice500ml
Copy link
Member Author

punkyoon added a commit that referenced this issue Mar 2, 2017
@punkyoon
Copy link
Member

punkyoon commented Mar 2, 2017

flake8에서 잡혔던 문제는 다 해결했고, 변수 이름 / 메소드(or함수) 이름 / 클래스 이름 짓는 법만 맞추면 될 듯 합니다.

@punkyoon
Copy link
Member

punkyoon commented Mar 12, 2017

Python

  • 변수 이름 ; underscore
  • 메소드(함수) 이름 ; underscore
  • 클래스 이름 ; Camel
  • 파일 이름 ; underscore

Javascript

  • 변수 이름 ; underscore
  • 메소드(함수) 이름 ; underscore
  • 클래스(네임스페이스) 이름 ; Camel
  • 파일 이름 ; underscore

@juice500ml
Copy link
Member Author

HTML이랑 CSS도 잡아야 합니다 ㅋㅋ

@juice500ml juice500ml reopened this Mar 12, 2017
@minhoryang
Copy link
Member

앜ㅋㅋㅋㅋ 이게 그거구나ㅋㅋㅋㅋ

@punkyoon
Copy link
Member

@juice500ml 나머지는 광희가..정하는걸로..!

@juice500ml
Copy link
Member Author

front쪽은 angluar/react 정해지면 그 스타일대로 가겠습니다~

@punkyoon
Copy link
Member

https://github.com/dduk-ddak/coding-night-live/blob/master/manage_room/views.py#L16

제가 위에서 정한 기준에 안맞아요...★ 집에가서 수정할게요.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants