Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Overhaul forms #23

Merged
merged 2 commits into from May 20, 2023
Merged

feat: Overhaul forms #23

merged 2 commits into from May 20, 2023

Conversation

dcramer
Copy link
Owner

@dcramer dcramer commented May 20, 2023

This migrates form validation to a combination of react-hook-form and zod. There's still some issues w/ the jsonschema generation (might be an upstream bug w/ the validator) in e.g. the notification serializer.

This also cleans up and simplifies some forms and components.

As part of this we're also changing rating to be optional which is a feature enhancement.

This adds an initial implementation of Zod for form validation on the add tasting flow, duplicating the schema on the API for consistency.

This also makes rating optional, to simplify check-in experiences if you just wanna record notes.
@dcramer dcramer merged commit 2a230b7 into main May 20, 2023
@dcramer dcramer deleted the feat/zod-validation branch May 20, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant