-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add suggestions for bottle details on AddBottle #144
Comments
Rethinking this a bit now... I think a better approach is to think of this as a forced normalization solution. That is, you submit bottle create/update, and we either show (or dont) what your input is going to transform into. Its like address normalization. The suggestions are still valuable, like suggesting the most likely matches for e.g. a distiller if you select a brand. Those howerver we can implement as a weight bias in each selection endpoint. In addition to doing this in the UI for the bottle normalization, we'll also utilize that exact same code to normalize the result in the API itself. |
- Adds entity aliases - Adds normalization to both update/create (still TBD how to expose to the user per GH-144) - Various improvements to the headers and list grids for many panels, including forms and list entries - Adds some basic weighting to distiller/bottler selections based on current context
There are various things we can auto fill in our prioritize in ranking in the add bottle flow. Its a bit overkill, but given the importance of this flow it feels worth it. This is likely best done by sending a request to an endpoint on every field change.
For example, you select "The Scotch Malt Whisky Society" as the brand, which is the first field. We can then suggest the bottler to be the same.
You then enter the cask #, not only can we suggest the name format (e.g. we could show similar bottles from a brand to help you), but in SMWS' case we can actually suggest the distiller.
Likely the endpoint returns two types of suggestions:
The text was updated successfully, but these errors were encountered: