Add Check to Verify queried_semantic_models
#1207
Draft
+40
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
approved these changes
May 12, 2024
| @@ -361,3 +362,16 @@ def test_case( | |||
| ) | |||
| # If we sort, it's effectively not checking the order whatever order that the output was would be overwritten. | |||
| assert_dataframes_equal(actual, expected, sort_columns=not case.check_order, allow_empty=case.allow_empty) | |||
|
|
|||
| # Check that the parse result and the dataflow plan show the same semantic models read. | |||
| if name in {"itest_dimensions.yaml/distinct_values_query_with_metric_filter"}: | |||
There was a problem hiding this comment.
@plypaul did some digging and it turns out this bug is not in the metric filters feature, it's in queries without metrics in general. You can see this test case gets the same error. I'll put up an issue to fix that, but you might want to update the message below to reflect that.
plypaul
force-pushed
the
p--smr--06
branch
2 times, most recently
from
a740810
to
a784bdf
Compare
plypaul
force-pushed
the
p--smr--05
branch
2 times, most recently
from
4feb4d6
to
04a0a16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a check to the integration test cases to verify that the queried semantic models returned by the parser match the semantic models queried in the dataflow plan.
Tagging @courtneyholcomb as there's currently a case that is skipped - do you have context offhand why that's the case?