You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched the existing issues, and I could not find an existing issue for this bug
Current Behavior
There was issue previously, but it was not fully solved. Meta and Tags are not supported in entities, measures, dimensions, but looks like should as per discussion.
An error occured Invalid semantic_models config given in FilePath ... at path ['<entity_name>'][<seq_number>]: Additional properties are not allowed ('<property_name>' was unexpected)
example Invalid semantic_models config given in FilePath ... at path ['entities'][0]: Additional properties are not allowed ('tags' was unexpected)
For comparison: semantic_models part supports config, and meta and tags can be added there (config was resolution of issue mentioned above). metrics part supports meta and tags as expected.
Moreover, these properties are absent in Discovery API (https://ye912.metadata.us1.dbt.com/graphql) (measure example on the screenshot). (separate feature can be submitted if it was done intentionally)
Expected Behavior
User is able to use Meta and Tags in semantic_model.yml (entities, measures, dimensions) and accessible via Discovery API.
semantic_models:
- name: transaction
model: ref('fact_transaction')
description: "Our transaction semantic_model. Config supported for semantic_models instead of meta. Meta and tags can be
added there"
default:
agg_time_dimension: transaction_date
config:
meta:
whatever_key: whatever_value
entities:
- name: transaction
type: primary
expr: transaction_id
meta:
whatever_key: whatever_value
tags: ["dev"]
dimensions:
- name: transaction_date
type: time
type_params:
time_granularity: day
meta:
whatever_key: whatever_value
tags: ["dev"]
measures:
- name: transaction_total
description: "The total value of the transaction"
agg: sum
meta:
whatever_key: whatever_value
tags: ["dev"]
metrics:
- name: revenue
description: "some description. Meta and tags supported for metrics"
meta:
whatever_key: whatever_value
tags: ["dev"]
type: simple
type_params:
measure: transaction_total
Steps To Reproduce
Add Meta or Tags properties to entities, measures or dimensions to semantic_model.yml
Run dbt parse
Get an error Invalid semantic_models config given in FilePath ... at path ['<entity_name>'][<seq_number>]: Additional properties are not allowed ('<property_name>' was unexpected)
example Invalid semantic_models config given in FilePath ... at path ['entities'][0]: Additional properties are not allowed ('tags' was unexpected)
For many measures, it would be convenient to add the create_metric: true configuration.
Because measures do not support meta or tags, we can't add them to measures. So to add these, we would still have to code out the metric itself, which is very work-intensive and not DRY.
Is this a new bug in metricflow?
Current Behavior
There was issue previously, but it was not fully solved.
Meta and Tags are not supported in
entities
,measures
,dimensions
, but looks like should as per discussion.An error occured
Invalid semantic_models config given in FilePath ... at path ['<entity_name>'][<seq_number>]: Additional properties are not allowed ('<property_name>' was unexpected)
example
Invalid semantic_models config given in FilePath ... at path ['entities'][0]: Additional properties are not allowed ('tags' was unexpected)
For comparison:
semantic_models
part supports config, and meta and tags can be added there (config was resolution of issue mentioned above).metrics
part supports meta and tags as expected.Moreover, these properties are absent in Discovery API (https://ye912.metadata.us1.dbt.com/graphql) (measure example on the screenshot). (separate feature can be submitted if it was done intentionally)
Expected Behavior
User is able to use Meta and Tags in semantic_model.yml (entities, measures, dimensions) and accessible via Discovery API.
Steps To Reproduce
Invalid semantic_models config given in FilePath ... at path ['<entity_name>'][<seq_number>]: Additional properties are not allowed ('<property_name>' was unexpected)
example
Invalid semantic_models config given in FilePath ... at path ['entities'][0]: Additional properties are not allowed ('tags' was unexpected)
Relevant log output
No response
Environment
Which database are you using?
bigquery
Additional Context
No response
The text was updated successfully, but these errors were encountered: