Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for missing actors page #85

Open
dbr opened this issue Jun 15, 2020 · 2 comments
Open

Add workaround for missing actors page #85

dbr opened this issue Jun 15, 2020 · 2 comments
Milestone

Comments

@dbr
Copy link
Owner

dbr commented Jun 15, 2020

Accessing the actors API endpoint for a show with no actors added will throw a tvdb_error as if the show is missing.

This is technically a bug with TVDB - it should return an empty list of actors, not 404.. but we can easily workaround this in the API wrapper (a non-existent show will error before that point)

@mueslo
Copy link

mueslo commented Aug 13, 2020

This ist still critical. The further down this has to be mitigated, the uglier it becomes, e.g. the only way to work around this is to have two tvdb_api.Tvdb instances, one of which does not query for actors, and have this one called if the first one errors out. Hideous.

@mueslo
Copy link

mueslo commented Oct 16, 2020

Any update? I heard back from TheTVDB and they will not be fixing it on their end (only in their next API version...)

@dbr dbr modified the milestones: v3.1, v3.2 Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants