Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing py.typed file #473

Closed
Akuli opened this issue Jul 6, 2021 · 2 comments · Fixed by #521
Closed

missing py.typed file #473

Akuli opened this issue Jul 6, 2021 · 2 comments · Fixed by #521
Labels
enhancement

Comments

@Akuli
Copy link
Contributor

Akuli commented Jul 6, 2021

IMO the code has enough type hints to consider this package typed, so we should add a py.typed file to make mypy not complain about missing stubs. Current situation, with import schedule on line 15 of my_project/__main__.py:

$ mypy my_project/
my_project/__main__.py:15: error: Skipping analyzing "schedule": found module but no type hints or library stubs
my_project/__main__.py:15: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 10 source files)
@kasium
Copy link

kasium commented Nov 25, 2021

@dbader @SijmenHuizenga seems this issue was to discussed yet. Would you be open to accept a PR for that?

@SijmenHuizenga
Copy link
Collaborator

Ah yes, let's do this! PR is welcome 🚀

@Akuli Akuli mentioned this issue Apr 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add py.typed file Akuli/schedule
3 participants
@SijmenHuizenga @kasium @Akuli