Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace slow performing CSS selectors #2968

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

refactor: replace slow performing CSS selectors #2968

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
800600a
refactor: replaced by simpler solution
mfranzke Aug 3, 2024
e0eb738
test: updated screenshot
mfranzke Aug 5, 2024
dac6427
Merge branch 'main' into 2967-slow-performance-css-selectors
mfranzke Aug 5, 2024
eb92100
Merge branch 'main' into 2967-slow-performance-css-selectors
mfranzke Aug 5, 2024
ce524e4
Merge branch 'main' into 2967-slow-performance-css-selectors
mfranzke Aug 8, 2024
c651585
Merge branch 'main' into 2967-slow-performance-css-selectors
mfranzke Aug 9, 2024
a7633b6
Merge branch 'main' into 2967-slow-performance-css-selectors
mfranzke Aug 9, 2024
f5eaa2e
Update navigation.scss
mfranzke Aug 21, 2024
b8e6f06
Merge branch 'main' into 2967-slow-performance-css-selectors
mfranzke Aug 22, 2024
60e9d00
Merge branch 'main' into 2967-slow-performance-css-selectors
mfranzke Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...DBNavigation-should-match-screenshot-1/DBNavigation-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 2 additions & 11 deletions packages/components/src/components/navigation/navigation.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,20 +80,11 @@
}
}
}
}

&:has([aria-current="page"]),
> .db-navigation-item {
&[aria-current="page"] {
@extend %show-db-puls-auto;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would certainly improve performance. Unfortunately, through this change NavigationItems are no longer marked as active if a nested NavigationItem has aria-current=“page”. From a11y point of view, we recommend that you only set aria-current=“page” to the anchor that points to the current page.

An alternative would be to use JS to set an “active” class from the innermost active NavigationItem to the outermost NavigationItem. But is that better than using the has-selector...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to remember that this wasn't even only about line 84 within the original file, but especially about the upfollowing 88 till 96, that even also provided a concatenated :has selector. I'll further investigate on this one.


menu {
// hide puls for non navigation items
:has([aria-current="page"]),
[aria-current="page"] {
&::after {
display: none;
}
}
}
}
}
}
Expand Down
Loading