Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: button with invalid variant prop renders now correctly #2521

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix: button with invalid variant prop renders now correctly #2521

wants to merge 5 commits into from

Conversation

bruno-sch
Copy link
Collaborator

Proposed changes

Fixes: #2444

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@bruno-sch bruno-sch added the 🐛bug Something isn't working label Apr 15, 2024
@github-actions github-actions bot added the 🏘components Changes inside components folder label Apr 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-button-invalid-variant-renders-incorrect

mfranzke
mfranzke previously approved these changes Apr 16, 2024
View reviewed changes
@mfranzke mfranzke self-assigned this Apr 16, 2024
@mfranzke mfranzke added this to the Open Beta Release milestone Apr 16, 2024
@mfranzke mfranzke enabled auto-merge April 16, 2024 05:52
@mfranzke mfranzke marked this pull request as draft April 16, 2024 05:53
auto-merge was automatically disabled April 16, 2024 05:53

Pull request was converted to draft

@mfranzke
Copy link
Member

@bruno-sch based on the screenshots, I would say, that we're not done yet.

nmerget
nmerget reviewed Apr 16, 2024
View reviewed changes
__snapshots__/button/component/chromium/DBButton-should-match-screenshot-for-variant-brand.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong ^.^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no way !

@mfranzke
Copy link
Member

@bruno-sch I would be perfectly fine to just close the ticket, as we've even also discussed as an option the other day. If someone doesn't follow the pattern and/or (in this case) does only provide the attribute, but no (mandatory) value at all, things might look incorrect and our components don't necessarily need to be totally resilient.

@mfranzke
Copy link
Member

@bruno-sch is this still relevant?

@mfranzke mfranzke modified the milestones: Open Beta Release (0.1.0), v0.5.0 Sep 26, 2024
@mfranzke mfranzke removed this from the v0.5.0 milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget left review comments

@mfranzke mfranzke mfranzke left review comments

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mfranzke mfranzke

Labels
🐛bug Something isn't working 🏘components Changes inside components folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DBButton: empty prop variant="" creates unexpected combination of variants filled and outlined
3 participants
@bruno-sch @mfranzke @nmerget