Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more a11y tests via axe-core #2571

Closed
mfranzke opened this issue Apr 23, 2024 · 3 comments · Fixed by #2581
Closed

Add more a11y tests via axe-core #2571

mfranzke opened this issue Apr 23, 2024 · 3 comments · Fixed by #2581
Labels
👂accessibility Accessibility issues/improvements 🍄🆙improvement New feature or request

Comments

@mfranzke
Copy link
Member

mfranzke commented Apr 23, 2024

To prevent problems like e.g. db-ui/core#820 we should further optimize our testing and linting.

see also #2579

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Apr 23, 2024
@mfranzke mfranzke added this to the Guidelines 3.0 RC milestone Apr 23, 2024
@nmerget nmerget added the 👂accessibility Accessibility issues/improvements label Apr 25, 2024
@nmerget
Copy link
Member

nmerget commented Apr 25, 2024

This was referenced Apr 25, 2024
@nmerget
Copy link
Member

nmerget commented Apr 25, 2024

I tested with lighthouse ci, and it takes very long in the CI.

Currently, we only need the accessibility feature which is provided by axe-core, which is already in our repo via playwright.
I will rename this issue and include axe to our showcase tests to fix those problems.

@nmerget nmerget changed the title Integrate lighthouse tests Add more a11y tests via axe-core Apr 25, 2024
@mfranzke
Copy link
Member Author

mfranzke commented Apr 25, 2024

I tested with lighthouse ci, and it takes very long in the CI.

Currently, we only need the accessibility feature which is provided by axe-core, which is already in our repo via playwright. I will rename this issue and include axe to our showcase tests to fix those problems.

I meant to use lighthouse not just for a11y, but also the other nice included test types, but let's focus on a11y first of all. I've added a new lighthouse issue to follow up with independently: #2582

@mfranzke mfranzke removed this from the Guidelines 3.0 RC milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👂accessibility Accessibility issues/improvements 🍄🆙improvement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants