db.insert with a callback does not work

[tobalsgithub]

It appears that db.insert does not work with a callback. The code involved is here: https://github.com/db-migrate/db-migrate-base/blob/master/index.js#L453

We never reassign the callback variable to arguments[3], so the callback is never called and the migration hangs.

It looks like at one point we did reassign the callback, but took that out in this commit: 8160337#diff-168726dbe96b3ce427e7fedce31bb0bc

A workaround is to convert to using the promise API.

Instead of

exports.up = function (db, callback) {
  db.insert('tablename', [ col1 ] , [ val1 ], callback);
};

do

exports.up = function (db) {
 return db.insert('tablename', [ col1 ], [ val1 ]);
};

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.