-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplicate work in deref-input-signals #545
Comments
Thanks for catching this, it does look like a bug. In 64f858c I extracted part of There was a bug in that code though, and I fixed it in 1e82e55. However, that also introduced unnecessary derefs that weren't actually used, except for the side-effects of logging the error. The second set of derefs can be removed, we just need to find the right place and conditions for the logging statement to run. |
In https://github.com/Day8/re-frame/blob/master/src/re_frame/subs.cljc#L188, the work of traversing & dereferencing is being done twice. It looks like the purpose of the inner
cond
form is to print a warning if an unexpected argument is passed in. Maybe we could move this check into the:else
clause ofmap-signals
, and allow for elision in prod? along the lines of:The text was updated successfully, but these errors were encountered: