Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update needed for the code from tensorflow 1.4.0 to tensorflow 2 #16

Open
SagarDollin opened this issue Aug 25, 2021 · 1 comment
Open

Comments

@SagarDollin
Copy link

Hi @davidtellez,
This is a great project to get started with CPC; however, while running this project in my local environment, I found that while most of the code is compatible, some lines of code are not very compatible with tensorflow 2. For example, fit_genererator throws a warning. Also, in the versions after tensorflow 2.1.0, it has been deprecated.

My proposal
I intend to do the following things to update the project for users using tensorflow 2.
1. Make the existing project compatible with tensorflow 2
2. The callbacks function can incentivize time to train the model and therefore try to look for an alternative, and I will also compare the results when we do not use callback.
3. The project uses LeakyRelu as the activation in many layers; since the loss function is binary_crossentropy, I propose that we use ReLU instead.

Please let me know if you are open to the suggestions made. Also, your feedback is appreciated. Once we are on board, I will be sharing the issues that I discussed in detail. I will provide detailed information about the challenges of running the tensorflow 1.4.0 project on the tensorflow 2 environments.

Question: If this task is assigned to me, should I create a PR for the master branch or create a new branch for the updates.

Note: I'm currently focussing on the train_mode.py file.

@943fansi
Copy link

Hi, @SagarDollin , I am also interested with this project, have you finished this work with tensorflow 2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants