Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nonSelectedText is ignored when disableIfEmpty is true #714

Closed
cwalv opened this issue Mar 15, 2016 · 5 comments · May be fixed by #1029
Closed

nonSelectedText is ignored when disableIfEmpty is true #714

cwalv opened this issue Mar 15, 2016 · 5 comments · May be fixed by #1029
Labels
bug

Comments

@cwalv
Copy link
Contributor

cwalv commented Mar 15, 2016

Using these options:

$el.multiselect({
    disableIfEmpty: true,
    disabledText: 'Loading ...',
    nonSelectedText: 'None Selected'
})

I would expect buttonText to be 'Loading ...' iff the multiselect is disabled, and nonSelectedText to be used if it's not disabled and no items are selected. Currently, if disabledText and disableIfEmpty are set, nonSelectedText is ignored.
@cwalv cwalv mentioned this issue Mar 15, 2016
Merged
@davidstutz davidstutz added the bug label Apr 17, 2016
@davidstutz
Copy link
Owner

Will look into it and the corresponding PR, thanks!

@davidstutz
Copy link
Owner

Merged #715.

@adeeb1 adeeb1 mentioned this issue Jun 9, 2018
Open
@mustafasalahuldin
Copy link

Why new implementation still has the conflict (v0.9.16)?

@tiesont
Copy link
Collaborator

tiesont commented Sep 6, 2021

The latest release is v1.1.1 - https://github.com/davidstutz/bootstrap-multiselect/releases/tag/v1.1.1.

@mustafasalahuldin
Copy link

Thanks @tiesont, but I guess this releas doesn't support bs < 4, does it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use disabledText only when multiselect is actually disabled adeeb1/bootstrap-multiselect
4 participants
@tiesont @cwalv @davidstutz @mustafasalahuldin