-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with viewport.destroy() when React component gets dismounted #473
Comments
Not sure if it will fix this for you but im just dismount the stage instead. |
Arthur is there a way to do that using the React Pixi stage component? |
Yup, you can use the key prop for the stage, set that key string in a state and update the key using set state to another value to cause re render of the canvas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've experienced a problem when I was destroying the viewport on component dismounting in React
the dismount logic is pretty straight-forward:
The problem occurs connected with removing event listeners from domElement when destroying - as in React dismounting, markup's being removed from DOM first and side effects get done secondy, thus it throws the error that there's no "removeEventListener" of "undefined", domElement doesn't exist already
As my current workaround, I'm just adding fake domElement because I see these final steps are only related to event listeners removing and they were blocking further going to super.destroy() part
I don't consider it a viewport library issue, as viewport's flow just wants to make things in right order, just was wondering if there's still some adjustments required that would allow to avoid such issues.
E.g. I could raise a small PR for checking existance of domElement while trying to destroy eventListeners
Thank you
The text was updated successfully, but these errors were encountered: