Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oas v2 rules applied to v3 spec #454

Open
stevenh opened this issue Feb 9, 2024 · 2 comments
Open

oas v2 rules applied to v3 spec #454

stevenh opened this issue Feb 9, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@stevenh
Copy link

stevenh commented Feb 9, 2024

When running vacuum against an openapi v3 spec it still reports failures for oas2-* rules for example oas2-api-host.

I would expect it to only apply the rules appropriate to the spec version.

Example header which I would expect the rules to consider.

openapi: 3.0.0
@stevenh
Copy link
Author

stevenh commented Feb 9, 2024

Looks like the issue occurs when --skip-check is requested, which seems to be an unintended side effect

@daveshanley
Copy link
Owner

Hmmm.. interesting. --skip-check should not lose fidelity on which spec is being looked at, it should just stop erroring out if it's not an openapi spec.

@daveshanley daveshanley added the bug Something isn't working label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants