Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Limited support of duckdb dbt adapter credentials #881

Closed
sergun opened this issue Apr 2, 2024 · 2 comments
Closed

Limited support of duckdb dbt adapter credentials #881

sergun opened this issue Apr 2, 2024 · 2 comments
Labels
bug Something isn't working triage

Comments

@sergun
Copy link

sergun commented Apr 2, 2024

As I see here:
https://github.com/datafold/data-diff/blob/master/data_diff/dbt_parser.py#L388-L392

dbt config parser implemented in data-diff does not cover configuration options of modern duckdb dbt adapter.
E.g. extensions and any s3 related settings are useful:
https://github.com/duckdb/dbt-duckdb?tab=readme-ov-file#duckdb-extensions-settings-and-filesystems

@sergun sergun added the bug Something isn't working label Apr 2, 2024
@github-actions github-actions bot added the triage label Apr 2, 2024
@sergun
Copy link
Author

sergun commented Apr 9, 2024

datadiff.PATCH
Hi!
Attached find quick patch to parse settings and extension sections from duckdb dbt config.

@glebmezh
Copy link
Contributor

Hi @sergun,

Thank you for trying out data-diff, for opening this issue, and even proposing a patch!

We made a hard decision to sunset the data-diff package and won't provide further development or support. Diffing functionality will continue to be available in Datafold Cloud. At the moment, support for DuckDB is on the roadmap for the cloud. Please feel free to contact us at [email protected] if you have any questions.

-Gleb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

2 participants