Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom model naming #347

Open
mattppal opened this issue Mar 21, 2023 · 1 comment
Open

Allow custom model naming #347

mattppal opened this issue Mar 21, 2023 · 1 comment
Labels
reviewed: yes Has undergone review triaged: no Hasn't been approved for future implementation

Comments

@mattppal
Copy link

Is your feature request related to a problem? Please describe.
Since dbt requires unique model names, our models are named by the convention models/schema/schema__table.sql. When running generate properties, the models are picked up by the wrong names, e.g.

Model locations.locations__county not materialized, did you execute dbt run?. 
Model locations.locations__state not materialized, did you execute dbt run?.

Where the models are actually named

locations.state
locations.county

Describe the solution you'd like
Allow for custom model naming conventions so that model names do not have to equal table names.

@github-actions github-actions bot added the triaged: no Hasn't been approved for future implementation label Mar 21, 2023
@BAntonellini BAntonellini added the reviewed: yes Has undergone review label Jun 7, 2023
@BAntonellini
Copy link
Collaborator

Hi @mattppal, thanks for your contribution.

In order for dbt-coves to generate property files properly, model data is obtained from your database through dbt adapter.

This means that both un-materialized and ephemeral models cannot be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed: yes Has undergone review triaged: no Hasn't been approved for future implementation
Projects
None yet
Development

No branches or pull requests

2 participants