Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use temp table to refactor materialized cte #16900

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

refactor: use temp table to refactor materialized cte #16900

wants to merge 9 commits into from

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Nov 21, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 21, 2024
@xudong963 xudong963 marked this pull request as draft November 21, 2024 05:41
@xudong963 xudong963 force-pushed the temp_table_m_cte branch 5 times, most recently from ba5f7d5 to b4ced32 Compare November 25, 2024 11:45
@xudong963
Copy link
Member Author

Wait #16941

@xudong963
Copy link
Member Author 

12_0005_changes_select:                                                 [ FAIL ] - result differs with:
--- /runner/_work/databend/databend/tests/suites/0_stateless/12_time_travel/12_0005_changes_select.result	2024-11-25 12:23:54.553130727 +0000
+++ /runner/_work/databend/databend/tests/suites/0_stateless/12_time_travel/12_0005_changes_select.stdout	2024-11-25 12:26:02.435793713 +0000
@@ -1,22 +1,15 @@
 latest snapshot should contain 2 rows
 2
 changes default snapshot at the first insertion
-1	1	DELETE	false
-2	1	DELETE	true
-2	2	INSERT	true
-3	3	INSERT	false
+Error: APIError: ResponseError with 1006: can not use temp table in http handler if cookie is not enabled
 changes default snapshot at the first insertion end the deletion
-1	1	DELETE	false
-2	1	DELETE	true
-2	2	INSERT	true
+Error: APIError: ResponseError with 1006: can not use temp table in http handler if cookie is not enabled
 changes append_only snapshot at the first insertion

can not use temp table in http handler if cookie is not enabled

http session for temp table has supported, is there a plan to update client? cc @everpcpc @sundy-li

@sundy-li
Copy link
Member

http session for temp table has supported, is there a plan to update client?

@youngsofun to support it.

@everpcpc
Copy link
Member

bendsql in runner upgraded to 0.23.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: use temp table to refactor materialized cte runtime.
3 participants
@xudong963 @sundy-li @everpcpc